connect: do not enforce Contact header in 1XX responses with To tag #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspiel1
reviewed
Dec 12, 2023
There are some SIP UAs which send 1XX responses with a To tag and without a Contact header.
maximilianfridrich
force-pushed
the
1XX_no_contact
branch
from
a0e965d
to
d1027d0
Compare
|
I was seeing this same issue with jmp.chat's SIP service, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some SIP UAs which send 1XX responses with a To tag and without a Contact header.
This is enforced since v3.4.0 (#878) and with this change (#1028) we increase the compatibility with other SIP stacks while still staying compliant.
E.g. Linphone only enforces sending of the Contact header when compiled with a special compile time option.
Further, Kamailio removed the enforcing of this header too.